Fat arrow functions in the counter example #1942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fits in well with what was leftover from #1800. Thanks! |
|
Thanks @timdorr for the quick review and for the reference to the issue! |
|
What's the purpose of using arrow function instead of class method? It seems to be noisy. |
|
@alexeyraspopov It auto binds the function. It removes the need to do manual binding like the example had before in the constructor. |
This was referenced Sep 12, 2016
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I would like to propose to add more ES6-like syntax in the examples.
This is an opinionated subject since we might want to stick with some more ES5-like syntax in order for new comers to not be intimidated by the syntax on top of redux.
Please let me know what you think.