fix(serverBareModulesPlugin): update require.resolve to use full import, update warning

[mcansh]

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

• Docs
• Tests

Testing Strategy:

[kentcdodds]

Thanks! I think we should probably have a test for this functionality (not just the warning, but that too). Could you implement that?

[mcansh]

Thanks! I think we should probably have a test for this functionality (not just the warning, but that too). Could you implement that?

i agree, in my initial PR i wasn't sure about the best way to test for that being that a missing dependency would fail the build in esbuild.build, but i'll look into how others are doing that detection (and how we are for esm warnings)

[changeset-bot]

🦋 Changeset detected

Latest commit: 09008c6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kentcdodds]

Coolio 👍 Thanks!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-de9fc05-20220712 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!