Skip to content

fix(serverBareModulesPlugin): update require.resolve to use full import, update warning #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 5 commits into from
Jul 11, 2022
+76 −19
Merged

fix(serverBareModulesPlugin): update require.resolve to use full import, update warning #3656

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca61624
fix(serverBareModulesPlugin): update require.resolve to use full impo…
mcansh Jul 5, 2022
dbe4163
test: initial pass at writing a test for missing modules
mcansh Jul 6, 2022
3b601b4
fix: use path as warning key
mcansh Jul 11, 2022
6b18244
Create yellow-flowers-trade.md
mcansh Jul 11, 2022
09008c6
test: path.join for importer
mcansh Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/remix-dev/compiler/plugins/serverBareModulesPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ export function serverBareModulesPlugin(
!/\bnode_modules\b/.test(importer)
) {
try {
require.resolve(packageName);
require.resolve(path);
} catch (error) {
onWarning(
`The path "${path}" is imported in ` +
`${relative(process.cwd(), importer)} but ` +
`${packageName} is not listed in your package.json dependencies. ` +
`${packageName} was not found in your node_modules. ` +
`Did you forget to install it?`,
packageName
);
Expand Down