Jsx fix 3519 #3653
Merged
Jsx fix 3519 #3653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobzhang
reviewed
Jul 4, 2019
| | Oval_string (s,_,_) -> | ||
| #else | ||
| | Oval_string s -> | ||
| | Oval_string (s,_,_) -> |
Member
There was a problem hiding this comment.
curious why this change is needed to make 4.06 build, should not it go from the first #if
Contributor
Author
There was a problem hiding this comment.
I'm not sure. My workflow is a little different from the recommended in CONTIBUTING.md - it's something like:
git pull
cd ocaml
git checkout 4.06.1+BS && git pull
cd ..
ninja -C jscomp -t clean
ninja -C jscomp # this command fails if I don't change to the three
yarn postinstall
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fix for 4.06 compilation of @react.component tags which would provide inconsistent return types. Also adds a test to prevent this functionality from breaking in 4.06 or 02 going forward.
Fixes 3519 round 2.
Main change is in the second commit. The first commit is a set of unrelated changes that came up when I built 4.06. Happy to delete that commit entirely if it makes things easier.