revert: drop Connect-RPC generated code, keep plain messages#30
Conversation
Remove the *connect packages, gRPC service stubs and the connectrpc generation template; the message set stays. Pin proto/api to the service-less protos and regenerate. Centrifugo keeps its native gRPC stubs (now with full go_package import paths). Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (27)
📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR reverts the repository back to “messages-only” protobuf output by removing Connect-RPC generated packages and most gRPC service stubs, while keeping message types intact. It also updates generation tooling and dependencies accordingly, and regenerates Centrifugo’s retained gRPC stubs with fully-qualified go_package import paths.
Changes:
- Removed all
*connectgenerated clients/handlers and the Connect-RPC buf generation template, plus theconnectrpc.com/connectmodule dependency. - Dropped generated gRPC service stubs and/or service descriptors for multiple APIs (keeping message types), reflected by regenerated
*.pb.gowithNumServices: 0in several packages. - Regenerated Centrifugo API/proxy outputs to use fully-qualified
go_packagepaths (notably changing their Go package names).
Reviewed changes
Copilot reviewed 34 out of 42 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tcp/v1/tcpV1connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| tcp/v1/service.pb.go | Regenerate descriptors to remove service definitions (messages remain). |
| tcp/v1/service_grpc.pb.go | Remove generated gRPC service stubs. |
| status/v2/statusV2connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| status/v2/service.pb.go | Remove generated service descriptor file. |
| status/v2/service_grpc.pb.go | Remove generated gRPC service stubs. |
| service/v1/serviceV1connect/service_rpc.connect.go | Remove generated Connect-RPC client/handler stubs. |
| service/v1/service_rpc.pb.go | Remove generated service descriptor file. |
| service/v1/service_rpc_grpc.pb.go | Remove generated gRPC service stubs. |
| resetter/v1/service.pb.go | Regenerate descriptors to remove service definitions (messages remain). |
| resetter/v1/service_grpc.pb.go | Remove generated gRPC service stubs. |
| resetter/v1/resetterV1connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| metrics/v1/service.pb.go | Regenerate descriptors to remove service definitions (messages remain). |
| metrics/v1/service_grpc.pb.go | Remove generated gRPC service stubs. |
| metrics/v1/metricsV1connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| Makefile | Stop running Connect-RPC buf generation; expand clean target paths. |
| lock/v1/service.pb.go | Remove generated service descriptor file. |
| lock/v1/service_grpc.pb.go | Remove generated gRPC service stubs. |
| lock/v1/lockV1connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| kv/v2/service.pb.go | Remove generated service descriptor file. |
| kv/v2/service_grpc.pb.go | Remove generated gRPC service stubs. |
| kv/v2/kvV2connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| jobs/v2/service.pb.go | Remove generated service descriptor file. |
| jobs/v2/service_grpc.pb.go | Remove generated gRPC service stubs. |
| jobs/v2/jobsV2connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| informer/v1/service.pb.go | Regenerate descriptors to remove service definitions (messages remain). |
| informer/v1/service_grpc.pb.go | Remove generated gRPC service stubs. |
| informer/v1/informerV1connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| http/v2/service.pb.go | Remove generated service descriptor file. |
| http/v2/service_grpc.pb.go | Remove generated gRPC service stubs. |
| http/v2/httpV2connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
| go.sum | Remove Connect-RPC dependency checksums. |
| go.mod | Drop connectrpc.com/connect from requirements. |
| centrifugo/proxy/v1/proxy.pb.go | Regenerate with fully-qualified go_package (and changed Go package name). |
| centrifugo/proxy/v1/proxy_grpc.pb.go | Regenerate gRPC stubs with updated Go package name. |
| centrifugo/api/v1/api.pb.go | Regenerate with fully-qualified go_package (and changed Go package name). |
| centrifugo/api/v1/api_grpc.pb.go | Regenerate gRPC stubs with updated Go package name. |
| buf.gen.connectrpc.yaml | Remove Connect-RPC buf generation template. |
| applogger/v2/service.pb.go | Regenerate descriptors to remove service definitions (messages remain). |
| applogger/v2/service_grpc.pb.go | Remove generated gRPC service stubs. |
| applogger/v2/apploggerV2connect/service.connect.go | Remove generated Connect-RPC client/handler stubs. |
Files not reviewed (7)
- applogger/v2/service.pb.go: Generated file
- centrifugo/api/v1/api.pb.go: Generated file
- centrifugo/api/v1/api_grpc.pb.go: Generated file
- centrifugo/proxy/v1/proxy.pb.go: Generated file
- centrifugo/proxy/v1/proxy_grpc.pb.go: Generated file
- informer/v1/service.pb.go: Generated file
- metrics/v1/service.pb.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # go.mod # go.sum
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Removes the *connect packages, gRPC service stubs and the connectrpc generation template; every message stays. proto/api is pinned to the service-less protos (roadrunner-server/api#76) and the tree is regenerated. Centrifugo keeps its native gRPC stubs, now with full go_package import paths.