revert: drop Connect-RPC service definitions, keep DTO messages#76
Merged
Conversation
The RPC transport returns to goridge/net-rpc; the api-go message set stays.
Remove the service{} blocks (and service-only proto files) added for
Connect-RPC, restore the pre-connect buf lint config.
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (11)
📝 WalkthroughWalkthroughThe PR updates Buf lint configuration, changes two Centrifugo Go package paths, removes multiple obsolete protobuf gRPC service definitions, and adds an explicit Informer response message. ChangesAPI contract cleanup
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR reverts the API surface away from Connect-RPC by removing protobuf service definitions (and service-only proto files), while retaining the DTO/message protos used by consumers. It also restores the prior Buf lint configuration approach and fixes Centrifugo protobuf go_package options to generate correct Go import paths.
Changes:
- Removed Connect-RPC
serviceblocks from multiple RoadRunner plugin proto files and deleted service-only proto files. - Restored pre-Connect Buf lint configuration shape (dropping prior RPC/service-related lint exceptions) and enforced
disallow_comment_ignores. - Fixed Centrifugo
go_packageoptions to use fully-qualified Go module import paths.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| roadrunner/api/tcp/v1/service.proto | Removed TCPService RPC service definition, leaving DTO messages. |
| roadrunner/api/status/v2/service.proto | Deleted service-only proto file containing StatusService. |
| roadrunner/api/service/v1/service_rpc.proto | Deleted service-only proto file containing ServiceManager RPCs. |
| roadrunner/api/resetter/v1/service.proto | Removed ResetterService RPC service definition, leaving DTO messages. |
| roadrunner/api/metrics/v1/service.proto | Removed MetricsService RPC service definition, leaving DTO messages. |
| roadrunner/api/lock/v1/service.proto | Deleted service-only proto file containing LockService. |
| roadrunner/api/kv/v2/service.proto | Deleted service-only proto file containing KvService. |
| roadrunner/api/jobs/v2/service.proto | Deleted service-only proto file containing JobsService. |
| roadrunner/api/informer/v1/service.proto | Removed InformerService RPC service definition, leaving DTO messages. |
| roadrunner/api/http/v2/service.proto | Deleted service-only proto file containing HttpProxyService. |
| roadrunner/api/centrifugo/proxy/v1/proxy.proto | Updated go_package to a fully-qualified Go import path. |
| roadrunner/api/centrifugo/api/v1/api.proto | Updated go_package to a fully-qualified Go import path. |
| roadrunner/api/applogger/v2/service.proto | Removed service definition and an now-unneeded import, leaving DTO message(s). |
| buf.yaml | Dropped prior lint exceptions, enabled disallow_comment_ignores, and retained ignore paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RPC transport returns to goridge/net-rpc; the message set introduced alongside Connect-RPC stays. Removes the service{} blocks (and service-only proto files), restores the pre-connect buf lint config, and brings in the centrifugo go_package fix from the abandoned temporal branch.
Summary by CodeRabbit