Skip to content

Conversation

@hexwhyzet
Copy link

@hexwhyzet hexwhyzet commented Sep 24, 2024

  1. Added progress bar to track status of cloud merging
    https://github.com/user-attachments/assets/241ba53c-1dfb-46f9-9478-193024615dfa

  2. Added timing stats to know timings for each tool's part. It has to be useful for tool optimisation in near future.

image

(word benchmark might be not good for such tool, but I haven't come with nothing better)

  1. Fixed bug in function filterByPosesProximity. It used RTree to thin out points, but it has primarily two cons: firstly, for loop closure it might be better to have two very close to each other points, secondly if you take a ride with car on the same route, thinking that it will increase quality of resulting map, the second lap will be fully removed by this filter, because we will remember each point on the first lap, and will not include points from the second lap counting them as very close points. So I removed RTree and made back old filtration that looked at only two close by time points.

  2. Fixed little bug with points filtration inside mergeCloudsByPointsSimilarity, on last iteration of most nested loop we had no chance to add selected point to the answer.

  3. Added RTree to selection of poses, which clouds we use in mergeCloudsByPointsSimilarity. In previous version we were selecting just nearby 20 poses and pick their clouds. Now we build RTree of poses and select no more than N poses not farther than M by distance.

@apmilko apmilko self-requested a review September 26, 2024 09:38
@apmilko apmilko marked this pull request as draft September 29, 2024 16:06
@apmilko apmilko self-assigned this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants