Enable github/workflow to verify Dockerfile. #5035

fujitatomoya · 2025-02-15T19:27:12Z

follow-up of #5021

github-actions · 2025-02-15T19:30:28Z

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13348160833/artifacts/2597631924.

To view the resulting site:

Click on the above link to download the artifacts archive
Extract it
Open html-artifacts-5035/index.html in your favorite browser

.github/workflows/docker-image.yml

docker/image/Dockerfile

Signed-off-by: Tomoya Fujita <[email protected]>

.github/workflows/docker-image.yml

fujitatomoya · 2025-02-15T19:58:24Z

@christophebedard could you take a look when you have time?

fujitatomoya · 2025-02-16T00:24:41Z

@christophebedard thanks!

@kscottz @Crola1702 just a note, after this PR is merged new github workflow is online. that workflow is only for https://github.com/ros2/ros2_documentation/blob/rolling/docker/image/Dockerfile that is used to generate the documentation with CI. this new github workflow makes sure generating documentation with docker build to work okay, so that we can detect this kind of CI doc regression before merge. besides, this new workflow is activated only when Dockerfile is updated, that means usually nobody gets bothered by this workflow during contribution unless they change something in Dockerfile.

Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 175e677)

Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 175e677) Co-authored-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>

* Sentence Checker * Some edits * Update About-Executors.rst * More sentence breaks * More cleanup * More sentences * Fix smart quotes * fix group tag indent for ROSCon 2023 and 2024 contents. (#5016) Signed-off-by: Tomoya Fujita <[email protected]> * Clean up sentences II (white space changes only) (#5017) * Exclude literals parts from bold parts in 'Ament Lint CLI Utilities' (#5024) You can't do nested inline markup in RST: **Can't do ``this`` in RST.** The simplest solution is to just exclude the ``literal`` part. Also, do some other minor fixes. Signed-off-by: Christophe Bedard <[email protected]> * remove --break-system-packages and address docker build warnings. (#5021) * remove --break-system-packages and address docker build warnings. Signed-off-by: Tomoya Fujita <[email protected]> * add github workflow to test Dockerfile. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "add github workflow to test Dockerfile." This reverts commit 8686f18. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> * More * Other sentence formatting (#5031) * Add second dot to abbreviations * Remove some random periods * Escape some periods * Convert some links * Add formatted block * Enable github/workflow to verify Dockerfile. (#5035) Signed-off-by: Tomoya Fujita <[email protected]> * Update Using-Node-Interfaces-Template-Class.rst (#5038) Added missing ``Output:`` before the terminal output for consistency reasons Signed-off-by: Nikos Tziaros <[email protected]> * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediat… (#5034) * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediate.rst * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate.rst Thanks for pointing it out, I didnt notice the extention beeing there Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> --------- Signed-off-by: Nikos Tziaros <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> * more bits * Some rollbacks * Ignore * Use sphinx_tamer * More Sphinx Config * Updated checker using subprocess * Make sphinx-lint-with-ros exit with non-zero error codes Signed-off-by: Shane Loretz <[email protected]> * Wrap r2d2.rviz in backticks Signed-off-by: Shane Loretz <[email protected]> * Wrap URL in RST link Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Use normalized project name sphinx-tamer Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Make sentence checker ignore `.idl` Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Nikos Tziaros <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]>

* Sentence Checker * Some edits * Update About-Executors.rst * More sentence breaks * More cleanup * More sentences * Fix smart quotes * fix group tag indent for ROSCon 2023 and 2024 contents. (#5016) Signed-off-by: Tomoya Fujita <[email protected]> * Clean up sentences II (white space changes only) (#5017) * Exclude literals parts from bold parts in 'Ament Lint CLI Utilities' (#5024) You can't do nested inline markup in RST: **Can't do ``this`` in RST.** The simplest solution is to just exclude the ``literal`` part. Also, do some other minor fixes. Signed-off-by: Christophe Bedard <[email protected]> * remove --break-system-packages and address docker build warnings. (#5021) * remove --break-system-packages and address docker build warnings. Signed-off-by: Tomoya Fujita <[email protected]> * add github workflow to test Dockerfile. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "add github workflow to test Dockerfile." This reverts commit 8686f18. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> * More * Other sentence formatting (#5031) * Add second dot to abbreviations * Remove some random periods * Escape some periods * Convert some links * Add formatted block * Enable github/workflow to verify Dockerfile. (#5035) Signed-off-by: Tomoya Fujita <[email protected]> * Update Using-Node-Interfaces-Template-Class.rst (#5038) Added missing ``Output:`` before the terminal output for consistency reasons Signed-off-by: Nikos Tziaros <[email protected]> * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediat… (#5034) * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediate.rst * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate.rst Thanks for pointing it out, I didnt notice the extention beeing there Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> --------- Signed-off-by: Nikos Tziaros <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> * more bits * Some rollbacks * Ignore * Use sphinx_tamer * More Sphinx Config * Updated checker using subprocess * Make sphinx-lint-with-ros exit with non-zero error codes Signed-off-by: Shane Loretz <[email protected]> * Wrap r2d2.rviz in backticks Signed-off-by: Shane Loretz <[email protected]> * Wrap URL in RST link Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Use normalized project name sphinx-tamer Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Make sentence checker ignore `.idl` Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Nikos Tziaros <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 784fd45) # Conflicts: # source/Installation/Alternatives/Windows-Development-Setup.rst

* Sentence Checker * Some edits * Update About-Executors.rst * More sentence breaks * More cleanup * More sentences * Fix smart quotes * fix group tag indent for ROSCon 2023 and 2024 contents. (#5016) Signed-off-by: Tomoya Fujita <[email protected]> * Clean up sentences II (white space changes only) (#5017) * Exclude literals parts from bold parts in 'Ament Lint CLI Utilities' (#5024) You can't do nested inline markup in RST: **Can't do ``this`` in RST.** The simplest solution is to just exclude the ``literal`` part. Also, do some other minor fixes. Signed-off-by: Christophe Bedard <[email protected]> * remove --break-system-packages and address docker build warnings. (#5021) * remove --break-system-packages and address docker build warnings. Signed-off-by: Tomoya Fujita <[email protected]> * add github workflow to test Dockerfile. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "add github workflow to test Dockerfile." This reverts commit 8686f18. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> * More * Other sentence formatting (#5031) * Add second dot to abbreviations * Remove some random periods * Escape some periods * Convert some links * Add formatted block * Enable github/workflow to verify Dockerfile. (#5035) Signed-off-by: Tomoya Fujita <[email protected]> * Update Using-Node-Interfaces-Template-Class.rst (#5038) Added missing ``Output:`` before the terminal output for consistency reasons Signed-off-by: Nikos Tziaros <[email protected]> * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediat… (#5034) * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediate.rst * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate.rst Thanks for pointing it out, I didnt notice the extention beeing there Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> --------- Signed-off-by: Nikos Tziaros <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> * more bits * Some rollbacks * Ignore * Use sphinx_tamer * More Sphinx Config * Updated checker using subprocess * Make sphinx-lint-with-ros exit with non-zero error codes Signed-off-by: Shane Loretz <[email protected]> * Wrap r2d2.rviz in backticks Signed-off-by: Shane Loretz <[email protected]> * Wrap URL in RST link Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Use normalized project name sphinx-tamer Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Make sentence checker ignore `.idl` Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Nikos Tziaros <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 784fd45) # Conflicts: # source/Installation/Alternatives/RHEL-Development-Setup.rst # source/Installation/Alternatives/Windows-Development-Setup.rst # source/Installation/_rosdep_Linux_Mint.rst

* Sentence checker (#4592) * Sentence Checker * Some edits * Update About-Executors.rst * More sentence breaks * More cleanup * More sentences * Fix smart quotes * fix group tag indent for ROSCon 2023 and 2024 contents. (#5016) Signed-off-by: Tomoya Fujita <[email protected]> * Clean up sentences II (white space changes only) (#5017) * Exclude literals parts from bold parts in 'Ament Lint CLI Utilities' (#5024) You can't do nested inline markup in RST: **Can't do ``this`` in RST.** The simplest solution is to just exclude the ``literal`` part. Also, do some other minor fixes. Signed-off-by: Christophe Bedard <[email protected]> * remove --break-system-packages and address docker build warnings. (#5021) * remove --break-system-packages and address docker build warnings. Signed-off-by: Tomoya Fujita <[email protected]> * add github workflow to test Dockerfile. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "add github workflow to test Dockerfile." This reverts commit 8686f18. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> * More * Other sentence formatting (#5031) * Add second dot to abbreviations * Remove some random periods * Escape some periods * Convert some links * Add formatted block * Enable github/workflow to verify Dockerfile. (#5035) Signed-off-by: Tomoya Fujita <[email protected]> * Update Using-Node-Interfaces-Template-Class.rst (#5038) Added missing ``Output:`` before the terminal output for consistency reasons Signed-off-by: Nikos Tziaros <[email protected]> * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediat… (#5034) * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediate.rst * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate.rst Thanks for pointing it out, I didnt notice the extention beeing there Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> --------- Signed-off-by: Nikos Tziaros <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> * more bits * Some rollbacks * Ignore * Use sphinx_tamer * More Sphinx Config * Updated checker using subprocess * Make sphinx-lint-with-ros exit with non-zero error codes Signed-off-by: Shane Loretz <[email protected]> * Wrap r2d2.rviz in backticks Signed-off-by: Shane Loretz <[email protected]> * Wrap URL in RST link Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Use normalized project name sphinx-tamer Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Make sentence checker ignore `.idl` Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Nikos Tziaros <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 784fd45) # Conflicts: # source/Installation/Alternatives/Windows-Development-Setup.rst * resolve conflict. Signed-off-by: Tomoya Fujita <[email protected]> * make linter happy. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: David V. Lu!! <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>

* Sentence checker (#4592) * Sentence Checker * Some edits * Update About-Executors.rst * More sentence breaks * More cleanup * More sentences * Fix smart quotes * fix group tag indent for ROSCon 2023 and 2024 contents. (#5016) Signed-off-by: Tomoya Fujita <[email protected]> * Clean up sentences II (white space changes only) (#5017) * Exclude literals parts from bold parts in 'Ament Lint CLI Utilities' (#5024) You can't do nested inline markup in RST: **Can't do ``this`` in RST.** The simplest solution is to just exclude the ``literal`` part. Also, do some other minor fixes. Signed-off-by: Christophe Bedard <[email protected]> * remove --break-system-packages and address docker build warnings. (#5021) * remove --break-system-packages and address docker build warnings. Signed-off-by: Tomoya Fujita <[email protected]> * add github workflow to test Dockerfile. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "add github workflow to test Dockerfile." This reverts commit 8686f18. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> * More * Other sentence formatting (#5031) * Add second dot to abbreviations * Remove some random periods * Escape some periods * Convert some links * Add formatted block * Enable github/workflow to verify Dockerfile. (#5035) Signed-off-by: Tomoya Fujita <[email protected]> * Update Using-Node-Interfaces-Template-Class.rst (#5038) Added missing ``Output:`` before the terminal output for consistency reasons Signed-off-by: Nikos Tziaros <[email protected]> * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediat… (#5034) * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediate.rst * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate.rst Thanks for pointing it out, I didnt notice the extention beeing there Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> --------- Signed-off-by: Nikos Tziaros <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> * more bits * Some rollbacks * Ignore * Use sphinx_tamer * More Sphinx Config * Updated checker using subprocess * Make sphinx-lint-with-ros exit with non-zero error codes Signed-off-by: Shane Loretz <[email protected]> * Wrap r2d2.rviz in backticks Signed-off-by: Shane Loretz <[email protected]> * Wrap URL in RST link Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Use normalized project name sphinx-tamer Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Make sentence checker ignore `.idl` Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Nikos Tziaros <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 784fd45) # Conflicts: # source/Installation/Alternatives/RHEL-Development-Setup.rst # source/Installation/Alternatives/Windows-Development-Setup.rst # source/Installation/_rosdep_Linux_Mint.rst * resolve conflicts. Signed-off-by: Tomoya Fujita <[email protected]> * make linter happy. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: David V. Lu!! <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>

fujitatomoya requested review from clalancette and audrow as code owners February 15, 2025 19:27

fujitatomoya force-pushed the fujitatomoya/enable-workflow-dockerfile branch from 1415b24 to d913359 Compare February 15, 2025 19:33

fujitatomoya commented Feb 15, 2025

View reviewed changes

.github/workflows/docker-image.yml Outdated Show resolved Hide resolved

fujitatomoya commented Feb 15, 2025

View reviewed changes

docker/image/Dockerfile Outdated Show resolved Hide resolved

fujitatomoya force-pushed the fujitatomoya/enable-workflow-dockerfile branch from d913359 to 997c8a7 Compare February 15, 2025 19:47

Enable github/workflow to verify Dockerfile.

7d0cdd9

Signed-off-by: Tomoya Fujita <[email protected]>

fujitatomoya force-pushed the fujitatomoya/enable-workflow-dockerfile branch from 997c8a7 to 7d0cdd9 Compare February 15, 2025 19:53

fujitatomoya commented Feb 15, 2025

View reviewed changes

.github/workflows/docker-image.yml Show resolved Hide resolved

.github/workflows/docker-image.yml Show resolved Hide resolved

fujitatomoya requested a review from christophebedard February 15, 2025 19:57

christophebedard approved these changes Feb 15, 2025

View reviewed changes

fujitatomoya self-assigned this Feb 16, 2025

fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Feb 16, 2025

fujitatomoya merged commit 175e677 into rolling Feb 16, 2025
6 checks passed

fujitatomoya deleted the fujitatomoya/enable-workflow-dockerfile branch February 16, 2025 00:25

mergify bot pushed a commit that referenced this pull request Feb 16, 2025

Enable github/workflow to verify Dockerfile. (#5035)

5f9d374

Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 175e677)

mergify bot pushed a commit that referenced this pull request Feb 16, 2025

Enable github/workflow to verify Dockerfile. (#5035)

8dd7710

Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 175e677)

This was referenced Feb 16, 2025

Enable github/workflow to verify Dockerfile. (backport #5035) #5036

Merged

Enable github/workflow to verify Dockerfile. (backport #5035) #5037

Merged

fujitatomoya added a commit that referenced this pull request Feb 16, 2025

Enable github/workflow to verify Dockerfile. (#5035) (#5037)

c2ba493

Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 175e677) Co-authored-by: Tomoya Fujita <[email protected]>

fujitatomoya added a commit that referenced this pull request Feb 16, 2025

Enable github/workflow to verify Dockerfile. (#5035) (#5036)

a8fdf13

Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 175e677) Co-authored-by: Tomoya Fujita <[email protected]>

DLu pushed a commit to DLu/ros2_documentation that referenced this pull request Feb 18, 2025

Enable github/workflow to verify Dockerfile. (ros2#5035)

16461f4

Signed-off-by: Tomoya Fujita <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable github/workflow to verify Dockerfile. #5035

Enable github/workflow to verify Dockerfile. #5035

fujitatomoya commented Feb 15, 2025

github-actions bot commented Feb 15, 2025 •

edited

Loading

fujitatomoya commented Feb 15, 2025

fujitatomoya commented Feb 16, 2025

Enable github/workflow to verify Dockerfile. #5035

Enable github/workflow to verify Dockerfile. #5035

Conversation

fujitatomoya commented Feb 15, 2025

github-actions bot commented Feb 15, 2025 • edited Loading

fujitatomoya commented Feb 15, 2025

fujitatomoya commented Feb 16, 2025

github-actions bot commented Feb 15, 2025 •

edited

Loading