-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Sentence checker (backport #4592) #5089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Sentence Checker * Some edits * Update About-Executors.rst * More sentence breaks * More cleanup * More sentences * Fix smart quotes * fix group tag indent for ROSCon 2023 and 2024 contents. (#5016) Signed-off-by: Tomoya Fujita <[email protected]> * Clean up sentences II (white space changes only) (#5017) * Exclude literals parts from bold parts in 'Ament Lint CLI Utilities' (#5024) You can't do nested inline markup in RST: **Can't do ``this`` in RST.** The simplest solution is to just exclude the ``literal`` part. Also, do some other minor fixes. Signed-off-by: Christophe Bedard <[email protected]> * remove --break-system-packages and address docker build warnings. (#5021) * remove --break-system-packages and address docker build warnings. Signed-off-by: Tomoya Fujita <[email protected]> * add github workflow to test Dockerfile. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "add github workflow to test Dockerfile." This reverts commit 8686f18. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> * More * Other sentence formatting (#5031) * Add second dot to abbreviations * Remove some random periods * Escape some periods * Convert some links * Add formatted block * Enable github/workflow to verify Dockerfile. (#5035) Signed-off-by: Tomoya Fujita <[email protected]> * Update Using-Node-Interfaces-Template-Class.rst (#5038) Added missing ``Output:`` before the terminal output for consistency reasons Signed-off-by: Nikos Tziaros <[email protected]> * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediat… (#5034) * added Publishing-Messages-Using-YAML-Files.rst and edited Intermediate.rst * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate.rst Thanks for pointing it out, I didnt notice the extention beeing there Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> * Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> --------- Signed-off-by: Nikos Tziaros <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> * more bits * Some rollbacks * Ignore * Use sphinx_tamer * More Sphinx Config * Updated checker using subprocess * Make sphinx-lint-with-ros exit with non-zero error codes Signed-off-by: Shane Loretz <[email protected]> * Wrap r2d2.rviz in backticks Signed-off-by: Shane Loretz <[email protected]> * Wrap URL in RST link Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Add empty line after section title Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Use normalized project name sphinx-tamer Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Make sentence checker ignore `.idl` Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Christophe Bedard <[email protected]> Signed-off-by: Nikos Tziaros <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Nikos Tziaros <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 784fd45) # Conflicts: # source/Installation/Alternatives/RHEL-Development-Setup.rst # source/Installation/Alternatives/Windows-Development-Setup.rst # source/Installation/_rosdep_Linux_Mint.rst
Cherry-pick of 784fd45 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
@DLu please review this one too. |
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13865464784/artifacts/2755726820. To view the resulting site:
|
source/Tutorials/Advanced/Simulators/Gazebo/Simulation-Gazebo.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoya Fujita <[email protected]>
99d08a0
to
056661a
Compare
@christophebedard i addressed your comments, can you check and merge? |
And now, a reading from the book of Code Style
@clalancette is a real stickler for this, so I made a linter. Unfortunately, there are lots of problems, some of which are the linter, and some of which are the content.
Happy to have help. I can't devote a ton more time to this, but I still wanted the code to be out there.
This is an automatic backport of pull request #4592 done by Mergify.