Skip to content

add more extra patterns to sentence scanner. (backport #5092) #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 14, 2025

lesson studied from #5088 and #5089


This is an automatic backport of pull request #5092 done by Mergify.

@mergify mergify bot added the conflicts label Mar 14, 2025
Copy link
Contributor Author

mergify bot commented Mar 14, 2025

Cherry-pick of 82dc620 has failed:

On branch mergify/bp/humble/pr-5092
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 82dc620.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .sphinx_tamer.yaml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to wait for #5089, and rebase.

Copy link

github-actions bot commented Mar 14, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13866526188/artifacts/2756077904.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5095/index.html in your favorite browser

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 14, 2025

@Mergifyio rebase

Copy link
Contributor Author

mergify bot commented Mar 14, 2025

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • #commits > 1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 82dc620)

# Conflicts:
#	.sphinx_tamer.yaml
@fujitatomoya fujitatomoya force-pushed the mergify/bp/humble/pr-5092 branch from 13e43b5 to 4961e08 Compare March 14, 2025 22:40
@fujitatomoya fujitatomoya merged commit 3244965 into humble Mar 14, 2025
5 checks passed
@fujitatomoya fujitatomoya deleted the mergify/bp/humble/pr-5092 branch March 14, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant