Skip to content

add more extra patterns to sentence scanner. #5092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fujitatomoya
Copy link
Collaborator

lesson studied from #5088 and #5089

@fujitatomoya fujitatomoya self-assigned this Mar 14, 2025
@fujitatomoya
Copy link
Collaborator Author

@DLu @christophebedard can you review this?

Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13850564486/artifacts/2750698059.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5092/index.html in your favorite browser

@fujitatomoya fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Mar 14, 2025
@fujitatomoya fujitatomoya merged commit 82dc620 into rolling Mar 14, 2025
5 checks passed
@fujitatomoya fujitatomoya deleted the fujitatomoya/more-extra-patterns-sentence-scan branch March 14, 2025 21:19
mergify bot pushed a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 82dc620)
mergify bot pushed a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 82dc620)

# Conflicts:
#	.sphinx_tamer.yaml
fujitatomoya added a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 82dc620)

Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 82dc620)

# Conflicts:
#	.sphinx_tamer.yaml
fujitatomoya added a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 82dc620)

# Conflicts:
#	.sphinx_tamer.yaml

Co-authored-by: Tomoya Fujita <[email protected]>
@DLu
Copy link
Contributor

DLu commented Mar 16, 2025

Belated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants