-
Notifications
You must be signed in to change notification settings - Fork 83
Finished CDL session 3 work #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cdl-65
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fisierul dynamic-linking nu e ok, titlul de PR mai explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply my suggestion then squash your two by two. There's no point in making WIP commits like your first and 3rd. Make sure the remaining 2 are formatted like so:
dynamic-linking.md: Fix errors
<then list your concrete changes below>
and
helloworld.md: Translate file to Markdown
<then list your concrete changes below>
Use git rebase -i HEAD~4
. This will open your default editor with the list of your 4 commits. Change the word pick
at the beginning of commits 2 and 4 to s
(from "squash"), then save and exit. This will open your default editor again with your first 2 commit messages. Edit them as specified above, then save and exit. Then do it again for the second batch of 2 commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed one backtick at __libc_start_main
.
dynamic-linking.md: Fix errors
Fixed mismatched markdown formating syntax(unclosed " * " and " ' " )
Changed round brackets to square when linking on last row
helloworld.md: Translate file to Markdown
Translated the entire helloworld-print.pdf to a mardkdown document