-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Implement feedbacks from #2071 for RSpec 4 #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* added generator for system spec * fixed spec for --no-system-specs * refactored to ensure that both usecases are using same path * Refere to system spec instead of feature spec * Specs need to be different for Rails under 5.1 * Don't provide system spec generator under Rails 5.1
Merged via rspec#2075
[skip ci]
Gemfile
Outdated
@@ -11,8 +11,9 @@ gem 'yard', '~> 0.8.7', :require => false | |||
|
|||
### deps for rdoc.info | |||
group :documentation do | |||
gem 'redcarpet', '2.3.0' | |||
gem 'github-markup', '1.0.0' | |||
gem 'redcarpet', '~> 3.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use exact pins. We want to pin to some low version, which is the lowest version that we support, such that as new versions get released, we know RSpec still works with old versions of those gems.
I'd say gem 'redcarpet', '3.4.x'
where x is the highest currently released version in the series, and the same for all other gems in this file.
@@ -23,6 +23,7 @@ | |||
gsub_file "Gemfile", /.*debugger.*/, '' | |||
gsub_file "Gemfile", /.*byebug.*/, "gem 'byebug', '~> 9.0.6'" | |||
gsub_file "Gemfile", /.*puma.*/, "" | |||
gsub_file "Gemfile", /.*sqlite3.*/, "gem 'sqlite3', '~> 1.3.6'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -23,8 +23,7 @@ def create_model_spec | |||
|
|||
def create_fixture_file | |||
return unless missing_fixture_replacement? | |||
|
|||
template 'fixtures.yml', File.join('spec/fixtures', "#{table_name}.yml") | |||
template 'fixtures.yml', File.join('spec/fixtures', class_path, "#{(pluralize_table_names? ? plural_file_name : file_name)}.yml") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@benoittgt small feedback about how the Gemfile is structured, otherwise this looks great, and thank you for your quick response! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
4defeec
to
c8e1ba5
Compare
No description provided.