Implement feedbacks from #2071 for RSpec 4 #2081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added generator for system spec * fixed spec for --no-system-specs * refactored to ensure that both usecases are using same path * Refere to system spec instead of feature spec * Specs need to be different for Rails under 5.1 * Don't provide system spec generator under Rails 5.1
Merged via rspec#2075
[skip ci]
Gemfile
Outdated
| @@ -11,8 +11,9 @@ gem 'yard', '~> 0.8.7', :require => false | |||
|
|
|||
| ### deps for rdoc.info | |||
| group :documentation do | |||
| gem 'redcarpet', '2.3.0' | |||
| gem 'github-markup', '1.0.0' | |||
| gem 'redcarpet', '~> 3.4' | |||
There was a problem hiding this comment.
please use exact pins. We want to pin to some low version, which is the lowest version that we support, such that as new versions get released, we know RSpec still works with old versions of those gems.
I'd say gem 'redcarpet', '3.4.x' where x is the highest currently released version in the series, and the same for all other gems in this file.
| @@ -23,6 +23,7 @@ | |||
| gsub_file "Gemfile", /.*debugger.*/, '' | |||
| gsub_file "Gemfile", /.*byebug.*/, "gem 'byebug', '~> 9.0.6'" | |||
| gsub_file "Gemfile", /.*puma.*/, "" | |||
| gsub_file "Gemfile", /.*sqlite3.*/, "gem 'sqlite3', '~> 1.3.6'" | |||
| @@ -23,8 +23,7 @@ def create_model_spec | |||
|
|
|||
| def create_fixture_file | |||
| return unless missing_fixture_replacement? | |||
|
|
|||
| template 'fixtures.yml', File.join('spec/fixtures', "#{table_name}.yml") | |||
| template 'fixtures.yml', File.join('spec/fixtures', class_path, "#{(pluralize_table_names? ? plural_file_name : file_name)}.yml") | |||
|
@benoittgt small feedback about how the Gemfile is structured, otherwise this looks great, and thank you for your quick response! |
benoittgt
force-pushed
the
4-0-Jon-Review
branch
from
4defeec to
c8e1ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.