-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Drop code related to Rails < 5.0 & Ruby < 2.3.0 #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2052a6d
to
8062d3f
Compare
This comment has been minimized.
This comment has been minimized.
bde195b
to
6020cc2
Compare
@JonRowe It's a big one, but mostly removals of old Rubies/Rails 3/4 support. Appreciate if you glance over. |
f679002
to
01567bf
Compare
For Rails 4.2 did you read this comment #2071 (comment) Thanks for the work. |
@benoittgt Thanks for pointing up, I completely missed the second part of this comment. |
Pretty much all of this was good to go @pirj I'd reopen it as is mostly.
This means we can remove all of our spec / feature tests for Rails 4.2
This means that we should leave the checks for 4.2 methods to check they are supported before calling in lib, and the same for files. However anything that is old Ruby is ok to be dropped. We're hard supporting 5.0 and soft supporting 4.2 but not old Ruby, thats gone.
This needs to be added somewhere. |
Sorry @pirj I was maybe not clear enough. But I don't this PR should be closed. :) |
@pirj let me know when this is ready to review again :) |
a552b5e
to
3218bd4
Compare
@JonRowe @benoittgt Please take another look. I broke four examples on 4.2,
expectedly get stuck at the point where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but I want to hold off final review until we've got green CI
3218bd4
to
0df1820
Compare
@JonRowe @benoittgt Green! |
One change really, only due to our process, currently the dev build should apply cleanly to rspec-rails and I'd like to keep it that way for centrally managed files |
0df1820
to
fc959be
Compare
fc959be
to
d52a135
Compare
All green. Reverted changes to predicate functions. Squashed commits. |
…s-4-checks Drop code related to Rails < 5.0 & Ruby < 2.3.0
Another cleanup attempt (former: #2225).
Note: in the Changelog, we state that we drop support for Ruby versions below 2.3, even though Rails 5.2 supports Ruby 2.2.2. It's a matter of getting just a couple lines back to keep 2.2.2 support.
I didn't dare to refactor
FixtureFileUploadSupport
.