Restore respond_to? check for default_url_options #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of d52a135. Feature example groups usually have a `default_url_options` class attribute, but it's not added if the method is already defined: https://github.com/rails/rails/blob/v6.0.2.1/actionpack/lib/action_dispatch/routing/url_for.rb#L92 Request example groups have a `default_url_options` instance method: https://github.com/rails/rails/blob/v6.0.2.1/actionpack/lib/action_dispatch/testing/integration.rb#L388 This means that when a feature example group is defined inside a request example group, it will only have the instance method, and trying to call `default_url_options` on the example group will fail.
|
I've merged this because I think its the easiest solution, we could probably find a better way of setting his, I ruled out |
|
@eugeneius thanks for the fix, I hope it's also would be in 4.0 release because beta4 breaks CI pipeline for me |
JonRowe
added a commit
that referenced
this pull request
Mar 13, 2020
Restore respond_to? check for default_url_options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2276.
Reverts part of #2226.
Feature example groups usually have a
default_url_optionsclass attribute, but it's not added if the method is already defined:https://github.com/rails/rails/blob/v6.0.2.1/actionpack/lib/action_dispatch/routing/url_for.rb#L92
Request example groups have a
default_url_optionsinstance method:https://github.com/rails/rails/blob/v6.0.2.1/actionpack/lib/action_dispatch/testing/integration.rb#L388
This means that when a feature example group is defined inside a request example group, it will only have the instance method, and trying to call
default_url_optionson the example group will fail.