-
-
Notifications
You must be signed in to change notification settings - Fork 288
Remove .ruby-version file #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b474395 to
1641a34
Compare
This PR removes the `.ruby-version` file The goal is to prevent forcing a specific Ruby version on contributors. Developers should be able to work on this repository regardless of their local Ruby version. * Previously, the Ruby version was pinned solely to address inconsistencies in hash syntax during documentation generation, not due to internal logic issues. * I believe pinning the version for this reason is not ideal. * With this change, documentation generation now produce consistent results without relying on a fixed Ruby version. * Contributors no longer need to worry about or strictly adhere to a specific Ruby version.
1641a34 to
3edcc98
Compare
|
I like this change, but shouldn't we see if we can make the patch in RuboCop instead? I imagine all of the RuboCop projects suffer from this Hash formatting issue. |
|
Probably, but this issue doesn't occur in rubocop/rubocop. I haven't investigated why, but it seems like some kind of countermeasure has been implemented. |
|
The following pull requests were created earlier. While it only required a few changes in rubocop-rspec, the other three repositories required changes in many places.
I think we should apply this change to the other three as well to improve consistency. Otherwise, I'm concerned it will be a lot of work to manually update 4.0 to 4.1 in so many locations again when Ruby 4.1 is released. What do you think? I believe it is a simple task since it just involves doing something similar, but the drawback is that every repository will end up containing a certain amount of workarounds. If you agree, I can handle all three tasks and submit the pull requests. |
Actually it seems that this issue does occur in rubocop/rubocop: |
This PR removes the
.ruby-versionfileWhy
The goal is to prevent forcing a specific Ruby version on contributors. Developers should be able to work on this repository regardless of their local Ruby version.
Details
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).