Fix a false positive for RSpec/ScatteredSetup when the hook is defined inside a class method

[d4rky-pl]

This PR fixes a false positive in RSpec/ScatteredSetup by ignoring the hooks defined inside class methods.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[bquorning]

I didn't want to chase this and figure out if this is Ruby version or some specific dependency getting silently updated due to unpinned version so I reverted those changes.

You should use Ruby 3.4 (as specified in .ruby-version), but an Ruby version agnostic alternative has been suggested in #2144. For now, reverting/ignoring the documentation change was the correct call. 👍🏼

[d4rky-pl]

@bquorning ah, that explains it, I'm using asdf without legacy_version_file enabled. I can confirm that after switching to 3.4 the docs are no longer updated in the wrong places. I'll remove the note from the description, thanks :)

[bquorning]

This looks useful. But it seems it doesn’t consider the other ways of defining class methods:

class << self
  def foo
  end
end

[d4rky-pl]

@bquorning I feel that the class << self is a bit of an edge case, not sure if anyone would think of using it inside describe block. I've added the support anyway and applied the other suggestion.

[bquorning]

@ydah What is your opinion?

[d4rky-pl]

@bquorning I had to push another fix because I've realized too late that it won't work with multiline class << self due to parser's implicit begin. It then took me forever to hit 100% coverage and 100% rubocop and have all the tests 😅

The PR should be OK now, apologies for pushing too soon.

[ydah]

Thank you!

[bquorning]

Thank you @d4rky-pl 🙏🏼