Deprecate Prism::Translation::Parser
#3526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep git history intact
Earlopain
force-pushed
the
parser-translator-no-ambiguous-version
branch
from
2cbf8ed to
43fdf3e
Compare
Earlopain
changed the title
Prism::Translator::ParserPrism::Translation::Parser
Either use `Prism::Translation::Parser34` or `Parser::Translation::ParserCurrent`. It's a remnamt of when prism was only able to parse a single ruby version. Every method instantiates the parser class, so a deprecation in `initialize` is good enough. In the future this can be cleaned up, currently the autload on the parser class is in the way.
Earlopain
force-pushed
the
parser-translator-no-ambiguous-version
branch
from
43fdf3e to
4318ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3524
Either use
Prism::Translation::Parser34orParser::Translation::ParserCurrent.It's a remnamt of when prism was only able to parse a single ruby version.
Every method instantiates the parser class, so a deprecation in just
initializeis good enough.In the future this can be cleaned up, currently the autload on the parser class is in the way.