Added attributes for distinguishing claims #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ttuegel
reviewed
Oct 14, 2019
|
I'd like to see a test for the case when the attribute is added to an individual sentence because it doesn't look like that case works to me. |
traiansf
force-pushed
the
one-path-all-path-claims
branch
from
43a11c9 to
9df5492
Compare
|
@dwightguth please take another look. |
dwightguth
approved these changes
Oct 17, 2019
|
Looks good but I'd like Tom to approve too before we merge. |
ttuegel
approved these changes
Oct 17, 2019
haskell-backend/src/main/java/org/kframework/backend/haskell/HaskellKRunOptions.java
Outdated
Show resolved
Hide resolved
…askellKRunOptions.java Co-Authored-By: Thomas Tuegel <[email protected]>
traiansf
force-pushed
the
one-path-all-path-claims
branch
from
66356f5 to
8728d9c
Compare
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
…ut (#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
…ut (#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to address an open issue for the Haskell backend the ability to distinguish between all path and one path claims: runtimeverification/haskell-backend#906