Update dependency: deps/pyk_release #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvacaru
approved these changes
Jan 24, 2024
anvacaru
approved these changes
Jan 25, 2024
|
This is a bug: https://github.com/runtimeverification/evm-semantics/actions/runs/7652685768/job/20853079912?pr=2272#step:7:2111 (Identifiers should start with Probably introduced in runtimeverification/pyk#832. I will investigate and prepare the fix. Edit: Fix: runtimeverification/pyk#840. |
|
Not sure if the failing proof is just flakiness, as it failed for me locally on this branch |
|
It appears that this test ( |
|
I have finally identified the regression which is causing (most) of the slowdown: runtimeverification/hs-backend-booster#470. The regression is caused by the huge amount of tracing data that the backend starts emitting after this change. The best course of action right now is probably to revert this PR and re-design the tracing to return less data. A second, smaller, but not insignificant regression was indeed caused by the switch to a threaded runtime in the booster. Whilst not totally unexpected, the regression is still noticeable and I will try to run further tests to see if this slowdown can be somewhat minimised. If tweaks to the runtime options don't produce a good enough result, we could start exporting two binaries in the booster. One threaded and one non-threaded and put the threaded server behind a flag for now. |
|
Update: Looks like the slowdown from the concurrent backend was just caused by running too many threads. Will set the default to 1 OS thread (currently set to the number of CPU cores). Here are the numbers with the above PR revert + 1 thread per rpc-booster:
|
rv-jenkins
pushed a commit
to runtimeverification/pyk
that referenced
this pull request
Jan 31, 2024
…ut (#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…ut (#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…ut (runtimeverification/pyk#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…ut (runtimeverification/pyk#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…ut (runtimeverification/pyk#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…ut (runtimeverification/pyk#842) We were having trouble in runtimeverification/evm-semantics#2272 selecting the correct claims because they can be unqualified by the user. This PR: - Fully qualifies all claim labels and dependency labels returned by `KProve.get_claim_modules`. - Makes sure that we return not only the user-selected claims, but their dependencies (unless the user turns that off), from `KProve.get_claims`. - Adds a test-suite for the claim selection functionality. There is a bug in this code, and a test added (and skipped using `pytest.skip()`) which demonstrates a (probably minor) issue where we are not checking that claim dependencies are in a module imported by the current module. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: #2276Blocked on: runtimeverification/pyk#842