This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Better handling of subproof dependencies when executing superproofs #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
force-pushed
the
more-kcfg-logs
branch
from
097c67d to
faf3d1a
Compare
|
I've confirmed that this enables a simple CSE on this branch of Kontrol: runtimeverification/kontrol#284 |
anvacaru
approved these changes
Jan 25, 2024
tothtamas28
approved these changes
Jan 25, 2024
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…untimeverification/pyk#832) ~Blocked on: runtimeverification/pyk#835 In this PR, we setup for CSE (compositional symbolic execution) in Kontrol. This PR enables using the existing subproof mechanism for setting up that possibility. In particular: - The method `KCFG.to_rules` is factored out of `KCFG.to_module`, to produce the list of rules associated with the basic blocks of the KCFG. - The injection of dependencies for a given subproof is modified to use this `KCFG.to_rules` instead, so that it is injecting the basic blocks of the subproof instead of the created transitino from init to target term. - A proof that was marked as `PENDING` before when having an un-admitted dependency is now marked as `FAILING` because of the more careful way we handle un-admitted dependencies when adding dependencies modules. - Improves the module name munging to produce Modules from KCFGs. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…untimeverification/pyk#832) ~Blocked on: runtimeverification/pyk#835 In this PR, we setup for CSE (compositional symbolic execution) in Kontrol. This PR enables using the existing subproof mechanism for setting up that possibility. In particular: - The method `KCFG.to_rules` is factored out of `KCFG.to_module`, to produce the list of rules associated with the basic blocks of the KCFG. - The injection of dependencies for a given subproof is modified to use this `KCFG.to_rules` instead, so that it is injecting the basic blocks of the subproof instead of the created transitino from init to target term. - A proof that was marked as `PENDING` before when having an un-admitted dependency is now marked as `FAILING` because of the more careful way we handle un-admitted dependencies when adding dependencies modules. - Improves the module name munging to produce Modules from KCFGs. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…untimeverification/pyk#832) ~Blocked on: runtimeverification/pyk#835 In this PR, we setup for CSE (compositional symbolic execution) in Kontrol. This PR enables using the existing subproof mechanism for setting up that possibility. In particular: - The method `KCFG.to_rules` is factored out of `KCFG.to_module`, to produce the list of rules associated with the basic blocks of the KCFG. - The injection of dependencies for a given subproof is modified to use this `KCFG.to_rules` instead, so that it is injecting the basic blocks of the subproof instead of the created transitino from init to target term. - A proof that was marked as `PENDING` before when having an un-admitted dependency is now marked as `FAILING` because of the more careful way we handle un-admitted dependencies when adding dependencies modules. - Improves the module name munging to produce Modules from KCFGs. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…untimeverification/pyk#832) ~Blocked on: runtimeverification/pyk#835 In this PR, we setup for CSE (compositional symbolic execution) in Kontrol. This PR enables using the existing subproof mechanism for setting up that possibility. In particular: - The method `KCFG.to_rules` is factored out of `KCFG.to_module`, to produce the list of rules associated with the basic blocks of the KCFG. - The injection of dependencies for a given subproof is modified to use this `KCFG.to_rules` instead, so that it is injecting the basic blocks of the subproof instead of the created transitino from init to target term. - A proof that was marked as `PENDING` before when having an un-admitted dependency is now marked as `FAILING` because of the more careful way we handle un-admitted dependencies when adding dependencies modules. - Improves the module name munging to produce Modules from KCFGs. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: #835In this PR, we setup for CSE (compositional symbolic execution) in Kontrol. This PR enables using the existing subproof mechanism for setting up that possibility. In particular:
KCFG.to_rulesis factored out ofKCFG.to_module, to produce the list of rules associated with the basic blocks of the KCFG.KCFG.to_rulesinstead, so that it is injecting the basic blocks of the subproof instead of the created transitino from init to target term.PENDINGbefore when having an un-admitted dependency is now marked asFAILINGbecause of the more careful way we handle un-admitted dependencies when adding dependencies modules.