This repository was archived by the owner on Mar 1, 2019. It is now read-only.
Produce more useful warnings when failing to load analysis files #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnalysisLoader implementations are expected to produce instances of this type, but if it's not public that's not possible. So it needs to be exported.
This uses the new rls-data to also check for version mismatches in case of failures. Additionally it upgrades the info! messages to warn! messages since that seems more appropriate, and adds an example program that can be used to exercise the code in question.
This was referenced Jul 25, 2018
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.