Update rls-data and rls-analysis versions

[staktrace]

I'd like to bump rls-analysis and rls-data to the latest available versions (0.16 and 0.18, respectively). Specifically to pick up the changes from rust-dev-tools/rls-analysis#147. It looks like this will need the three-step update process described at https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#breaking-tools-built-with-the-compiler. I will attempt to create the appropriate patches.

/cc @nrc

[staktrace]

Also /cc @emilio since he also made changes to rls-analysis and might be interested in this.

[emilio]

I guess updating it in the compiler before rls was the way to go? I submitted rust-lang/rls#973 but never got an answer about how to do this. Thanks for doing this!

[staktrace]

I guess updating it in the compiler before rls was the way to go?

I've never done it before, but that's what the documentation seems to imply. AFAICT step 1 is land it in rustc, step is land the RLS change, and step 3 is update the submodule in rustc to point to the new RLS.

[nrc]

but never got an answer about how to do this

oh crap, sorry!

step 1 is land it in rustc, step is land the RLS change, and step 3 is update the submodule in rustc to point to the new RLS

That's correct.

[staktrace]

Parts 1 and 2 have landed, so I made a PR for part 3. #53649

[staktrace]

This is done.