You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm getting the following error when trying to compile the library with rust 1.43.1:
error: trait objects without an explicit `dyn` are deprecated
--> src/fmt.rs:6:29
|
6 | impl<Word, Error> Write for ::serial::Write<Word, Error=Error>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn (::serial::Write<Word, Error=Error>)`
|
Only way I can see to make it compile is by removing #![deny(warnings)] from lib.rs, but that doesn't seem right?
I'm also not getting why I can reference the embedded-hal crate from another project (embedded-hal = "0.2.3") without issues, but if I reference the code (embedded-hal = { path="../../embedded-hal/" }) I get the above mentioned error?
Thanks in advance,
The text was updated successfully, but these errors were encountered:
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin
This fixes#213. Additionally I removed #[deny(warnings)] but added a check for it on CI.
I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while.
I can do that in a separate PR.
Co-authored-by: Diego Barrios Romero <[email protected]>
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin
This fixes#213. Additionally I removed #[deny(warnings)] but added a check for it on CI.
I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while.
I can do that in a separate PR.
Co-authored-by: Diego Barrios Romero <[email protected]>
Hi,
I'm getting the following error when trying to compile the library with rust 1.43.1:
Only way I can see to make it compile is by removing
#![deny(warnings)]
fromlib.rs
, but that doesn't seem right?I'm also not getting why I can reference the embedded-hal crate from another project (
embedded-hal = "0.2.3"
) without issues, but if I reference the code (embedded-hal = { path="../../embedded-hal/" }
) I get the above mentioned error?Thanks in advance,
The text was updated successfully, but these errors were encountered: