Skip to content

error: trait objects without an explicit dyn are deprecated #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reneherrero opened this issue May 27, 2020 · 1 comment
Closed

error: trait objects without an explicit dyn are deprecated #213

reneherrero opened this issue May 27, 2020 · 1 comment

Comments

@reneherrero
Copy link

Hi,

I'm getting the following error when trying to compile the library with rust 1.43.1:

error: trait objects without an explicit `dyn` are deprecated
   --> src/fmt.rs:6:29
    |
6   | impl<Word, Error> Write for ::serial::Write<Word, Error=Error>
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn (::serial::Write<Word, Error=Error>)`
    |

Only way I can see to make it compile is by removing #![deny(warnings)] from lib.rs, but that doesn't seem right?

I'm also not getting why I can reference the embedded-hal crate from another project (embedded-hal = "0.2.3") without issues, but if I reference the code (embedded-hal = { path="../../embedded-hal/" }) I get the above mentioned error?

Thanks in advance,

bors bot added a commit that referenced this issue May 27, 2020
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin

This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI.
I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while.
I can do that in a separate PR.

Co-authored-by: Diego Barrios Romero <[email protected]>
bors bot added a commit that referenced this issue Jun 10, 2020
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin

This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI.
I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while.
I can do that in a separate PR.

Co-authored-by: Diego Barrios Romero <[email protected]>
@ryankurte
Copy link
Contributor

Thanks for the report! This should be resolved in 0.2.4 and in the current (unreleased) branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants