Provide v2_compat for ToggleableOutputPin #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little-arhat
requested review from
ilya-epifanov,
thejpster and
a team
as code owners
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @hannobraun (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
bors r=ryankurte |
bors bot
added a commit
that referenced
this pull request
May 13, 2019
138: Provide v2_compat for ToggleableOutputPin r=ryankurte a=little-arhat fixes #137 Co-authored-by: Roma Sokolov <[email protected]>
Build failed |
|
Fixed tests. |
|
@bors[bot] r? bors r? hm |
|
@hannobraun @ilya-epifanov @thejpster do you have any objections to merging this? |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
ryankurte
approved these changes
May 14, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 14, 2019
138: Provide v2_compat for ToggleableOutputPin r=ryankurte a=little-arhat fixes #137 Co-authored-by: Roma Sokolov <[email protected]>
Build succeeded |
bors bot
added a commit
that referenced
this pull request
May 27, 2020
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI. I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while. I can do that in a separate PR. Co-authored-by: Diego Barrios Romero <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 10, 2020
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI. I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while. I can do that in a separate PR. Co-authored-by: Diego Barrios Romero <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 10, 2020
220: [0.2.x] Fixes to digital compatibility shim r=ryankurte a=eldruin I cherry-picked #138 and some improvements to docs and included #199. Co-authored-by: Roma Sokolov <[email protected]> Co-authored-by: Ryan Kurte <[email protected]> Co-authored-by: Diego Barrios Romero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #137