Skip to content

separate generic mod #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Aug 2, 2019

Adds option -g which when enabled store contents of generic.rs in separate file.

It's useful for common crates like stm32f1 where one crate for several pacs.

Uses syn::parse instead of vector of quote!.

@burrbull burrbull requested a review from a team as a code owner August 2, 2019 12:03
@rust-highfive
Copy link

r? @Emilgardis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Aug 2, 2019
@burrbull
Copy link
Member Author

burrbull commented Aug 2, 2019

r? @therealprof

#360

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Aug 3, 2019
362: separate generic mod r=therealprof a=burrbull

Adds option `-g` which when enabled store contents of `generic.rs` in separate file.

It's useful for common crates like `stm32f1` where one crate for several `pac`s.

Uses `syn::parse` instead of vector of `quote!`.

Co-authored-by: Andrey Zgarbul <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 3, 2019

Build succeeded

@bors bors bot merged commit 1e63cce into rust-embedded:master Aug 3, 2019
@burrbull burrbull deleted the separate-generic branch August 3, 2019 13:58
bors bot added a commit to stm32-rs/stm32-rs that referenced this pull request Aug 16, 2019
271: generics, svd2rust 0.16 r=adamgreig a=burrbull

Add support of new svd2rust.

Depends on rust-embedded/svd2rust#362 

Co-authored-by: Andrey Zgarbul <[email protected]>
@Emilgardis Emilgardis mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants