Newsyn #364
Newsyn #364
Conversation
rust-highfive
added
S-waiting-on-review
|
Nice cheat! I was actually trying to do the same but getting rid of the |
|
Please, merge #362 . |
| @@ -213,24 +213,25 @@ pub fn fields( | |||
| } = f.bit_range; | |||
| let sc = f.name.to_sanitized_snake_case(); | |||
| let pc = f.name.to_sanitized_upper_case(); | |||
| let pc_r = Ident::from(&*format!("{}_A", pc)); | |||
There was a problem hiding this comment.
Why all the from -> new changes? I've introduced the from so the update wouldn't require so many changes.
There was a problem hiding this comment.
I couldn't to make From on new syn to work.
Maybe some features disabled?
There was a problem hiding this comment.
Probably. from should be the same as new but automatically using the current call site as span but maybe that has changed again in a newer version.
There was a problem hiding this comment.
the trait `std::convert::From<&str>` is not implemented for `proc_macro2::Ident`
There was a problem hiding this comment.
syn reexport Ident from proc_macro2 now
There was a problem hiding this comment.
Meh, this is all so weird.
There was a problem hiding this comment.
Okay, fine, let's go full on nuts with this. Will need proper testing though.
tryBuild succeeded |
|
This branch compiles in configuration with last quote-next = "1.0.0-rc1"
svd-parser = "0.7"
proc-macro2-next = "1.0.0-rc1"
[dependencies.syn-next]
version = "1.0.0-rc1"
features = ["full","extra-traits"]So, I think PR can be merged. |
|
Rebased on master. |
|
syn v1.0 |
|
@therealprof Is there something blocking merge? |
|
bors r+ |
364: Newsyn r=therealprof a=burrbull r? @therealprof New `syn`, `quote` and `proc_macro2`. Co-authored-by: Andrey Zgarbul <[email protected]>
Build failed |
|
bors retry r=therealprof |
|
🔒 Permission denied Existing reviewers: click here to make burrbull a reviewer |
|
I've added you to bors so you should be able to try/retry now on this repository. |
|
Thank you. |
|
bors retry r=therealprof |
364: Newsyn r=therealprof a=burrbull r? @therealprof New `syn`, `quote` and `proc_macro2`. Co-authored-by: Andrey Zgarbul <[email protected]>
Build failed |
|
bors retry r=therealprof |
364: Newsyn r=therealprof a=burrbull r? @therealprof New `syn`, `quote` and `proc_macro2`. Co-authored-by: Andrey Zgarbul <[email protected]>
Build succeeded |
r? @therealprof
New
syn,quoteandproc_macro2.