Repository navigation
Fix SourceAnnotation ranges and refactor to std::fmt::Display - #27
Conversation
|
This PR looks awesome! Thank you so much! for |
|
Ok, should panic |
|
Can you mark this PR as draft until you're ready for review? I'm excited to review it :) |
|
It seems that the coverage is not correct. In the report details: So I think there are more bugs. So I will review that part of the logic. |
std::fmt::Display
|
Should already be presentable and debb3e2 doubles performance |
zbraniecki
left a comment
There was a problem hiding this comment.
Overall - very impressive! Thank you! The patch looks great and is definitely a significant clean up!
Several leftovers:
- the format example crashes, fix the second annotation to
(21,724)(I assume the new values are a fix to calculations) - same with the bench
- your branch seem to have broken color mode -
cargo run --example format --features color.
|
The changes are already there. A detail is that the ranges are start at 0, it should start at 1. Well but for this PR there is already enough, |
|
Thank you! This looks awesome! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [automod](https://redirect.github.com/dtolnay/automod) | dev-dependencies | patch | `1.0.14` -> `1.0.15` | --- ### Release Notes <details> <summary>dtolnay/automod (automod)</summary> ### [`v1.0.15`](https://redirect.github.com/dtolnay/automod/releases/tag/1.0.15) [Compare Source](https://redirect.github.com/dtolnay/automod/compare/1.0.14...1.0.15) - Documentation improvements </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/epage/_rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
In
test_i26what should be the output?panic or anything other than the label disappearing?
I would panic or even refactor to TryFrom. What you prefer
Fix #26