Upgrade annotate-snippets to 0.9.1

[zanieb]

Hi!

This upgrades use of the annotate-snippets dependency to be compatible with the latest version — 0.9.1.

They made a few changes, notably:

• Strings are borrowed instead of copied
• The DisplayListFormatter has been replaced with std::format::Display

I'm new to Rust so any feedback is very welcome! I'm not sure but I presume the changes from impl ToString to &'a str are not always backwards compatible?

[jelmer]

This would be great to see land - I've just cherry-picked it for the debian package of chic.

[sgammon]

@zanieb fancy seeing you here

[zanieb]

:) my pre-hire ambition to make Astral's Ruff builds a tiny bit faster by de-duplicating dependencies. Maybe I should revisit this now that I actually know Rust!

[jelmer]

@yoshuawuyts anything we can do to help this land?

[zanieb]

There hasn't been a commit here in 5 years, it seems unlikely? Are you looking for a new maintainer?

[plugwash]

For what it's worth I just prepared patches for Debian building on top of our cherry-pick of this patch, upgrading to 0.10 and 0.11.

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/chic/debian/patches/annotate-snippets-0.10

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/chic/debian/patches/annotate-snippets-0.11

[decathorpe]

I've taken these patches and applied them to the Fedora package too, but it looks like they actually introduce unintentional API changes, which make the libcst crate fail to compile :(

[zanieb]

Yeah I made these changes before I really knew Rust — these are definitely breaking changes and should come with a version bump. It doesn't really seem worth creating a non-breaking patch? I could look into it if it's meaningful though.

It looks Debian applies this https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/libcst/debian/patches/chic-api

[decathorpe]

Oh, great, looks like I can just take that additional patch, thanks!

[zanieb]

The downstream packaging toil has prompted me to go try to fix this at the source Instagram/LibCST#1293

[zanieb]

And that's been merged! Since it's unmaintained, hopefully this just removes chic from your dependency tree.

Let me know if there's another common package depending on it.