Skip to content

incompatible_msrv does not seem to be launched in 1.77 #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robertbastian opened this issue Mar 21, 2024 · 4 comments · Fixed by #1278
Closed

incompatible_msrv does not seem to be launched in 1.77 #1277

robertbastian opened this issue Mar 21, 2024 · 4 comments · Fixed by #1278

Comments

@robertbastian
Copy link

robertbastian commented Mar 21, 2024 •
edited
Loading

Description

It triggers an unknown lint warning.

See this playground, clippy-stable (1.77) doesn't know the lint, beta (1.78-beta-1) does though.

Version

No response

Additional Labels

No response
@Manishearth
Copy link
Member

this is a bug in the blog post, the list of new lints appears correct in the changelog

@Manishearth Manishearth transferred this issue from rust-lang/rust-clippy Mar 21, 2024
@Manishearth
Copy link
Member

https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#clippy-adds-a-new-incompatible_msrv-lint this section should be removed and reused for the 1.78 release

cc @Mark-Simulacrum and @rust-lang/release

Manishearth added a commit to rust-lang/rust-clippy that referenced this issue Mar 21, 2024
@Manishearth
Correct version for incompatible_msrv
87b9352 
Unsure what happened here

Probably what caused rust-lang/blog.rust-lang.org#1277
@Manishearth Manishearth mentioned this issue Mar 21, 2024
Merged
@Mark-Simulacrum
Copy link
Member

I'm happy to merge a PR dropping it, won't have a chance to put that together for some time.

@ehuss ehuss mentioned this issue Mar 21, 2024
Merged
@weihanglo
Copy link
Member

So it was the lint didn't make it into the release train I guess?

https://github.com/rust-lang/rust-clippy/blob/443f459f98841001b2c2041adda05b9318f44b24/clippy_lints/src/incompatible_msrv.rs#L36-L37

bors added a commit to rust-lang/rust-clippy that referenced this issue Mar 22, 2024
@bors
Auto merge of #12522 - rust-lang:Manishearth-patch-1, r=xFrednet
fc053c3 
Correct version for incompatible_msrv

Unsure what happened here

Probably what caused rust-lang/blog.rust-lang.org#1277

changelog: none
@thoughtpolice thoughtpolice mentioned this issue Apr 4, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove incompatible_msrv from 1.77 release. ehuss/blog.rust-lang.org
4 participants
@Manishearth @robertbastian @Mark-Simulacrum @weihanglo