-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Correct version for incompatible_msrv #12522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unsure what happened here Probably what caused rust-lang/blog.rust-lang.org#1277
I explicitly checked the changelog but the entry was generated after I suggested it go into the blog post. In Cargo, we generate the beta changelog entry when branched from master which would have made it available and this would have been caught. |
This was the correct version when the lint PR was created and a great example, why nightly lints would be awesome. I usually update the version attributes when I write the changelog for that version. But this sadly creates a desync. I'd correct this version, when I write the changelog for 1.78. |
FWIW, rust-lang/rust has a magic string and script that we bump version numbers for during nightly -> beta promotion (when the version number becomes fixed). See https://github.com/rust-lang/rust/blob/master/src/tools/replace-version-placeholder/src/main.rs for the script. If clippy wanted to, you could likely rely on us running that script and picking up the version numbers in a subsequent subtree sync? |
That's something I haven't considered before. Thank you for the idea, I'll investigate it, when I find the time :D |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Unsure what happened here
Probably what caused rust-lang/blog.rust-lang.org#1277
changelog: none