Skip to content

First draft of primitive types #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2015
Merged

First draft of primitive types #34

merged 1 commit into from
Dec 18, 2015

Conversation

steveklabnik
Copy link
Member

I moved slices to references, since they are references, and explaining
them right now is just more complex. I might do that with &str too...

#9

I moved slices to references, since they are references, and explaining
them right now is just more complex. I might do that with `&str` too...
steveklabnik added a commit that referenced this pull request Dec 18, 2015
First draft of primitive types
@steveklabnik steveklabnik merged commit ff6e452 into master Dec 18, 2015
@steveklabnik steveklabnik deleted the section_three branch December 18, 2015 19:48
```

If we run this example, we will get an error.
Let’s re-use our `functions` project from before.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: reuse doesn't need a dash

@mdinger
Copy link

mdinger commented Dec 22, 2015

I think this reads fine in general. What I'm unsure of is whether it is a good idea to explain Debug and panic here. While it does make a lot of sense to place them here in this context, they also appear elsewhere in many other independent contexts. In those cases, it may not be obvious where Debug and panic are explained and may be very surprising to only find them in the arrays section.

Having said that, if this is the only current explanation of those topics, put them in. Later when more expansive sections are present which cover those topics, you could defer to them a little more.

Really nice that these sections are being added.

Woah, this is a new repo. I guess I missed that happening.

@steveklabnik
Copy link
Member Author

What I'm unsure of is whether it is a good idea to explain Debug and panic here. While it does make a lot of sense to place them here in this context, they also appear elsewhere in many other independent contexts.

In general, this is an aside, to explain the bits now. It's not "the place you go to look up panic"

Woah, this is a new repo. I guess I missed that happening.

https://users.rust-lang.org/t/what-are-you-folks-working-on-this-week-51-2015/3957/2 :)

@mdinger
Copy link

mdinger commented Dec 22, 2015

That's so cool and it's really great you're testing out mdbook at this larger scale. It really helps to keep the developer wanting to push it forward. Really cool.

jossue33 pushed a commit to jossue33/book that referenced this pull request Feb 17, 2018
Corrections made to ch01-00-introduction.md
tatsuya6502 referenced this pull request in rust-lang-ja/book-ja Nov 21, 2019
Chapter 8.2 リストの参照を修正
amitu pushed a commit to FifthTry/rust-book that referenced this pull request Jun 1, 2021
Adding terms translations from ch02-00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants