chore(frontend): upgrade ember-fetch to prevent verbose warnings #1943
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Good news: using this PR, building and testing locally no longer shows the browserslist warning! 🎉
Bad news: There's still one showing up in CI, which I can't reproduce locally 🤔
There are also a lot of new warnings about FetchAdapter that happen on this PR and that don't happen on master, do you mind looking into those and seeing if they're easy to fix?
Looking at the package-lock.json diff, it looks like we've added browserslist 4.8.2 but haven't removed any, so I wonder if this issue is bigger than I thought and we perhaps need to update more packages? Are you interested in investigating this a bit more?
Thank you so much!
|
☔ The latest upstream changes (presumably #1957) made this pull request unmergeable. Please resolve the merge conflicts. |
|
whoops, totally missed this PR. #1981 did the same thing so I'll go ahead and close this one but @carols10cents comments are still valid. we should figure out how to resolve the FetchAdapter warnings. It might be just by updating ember-data. |
|
FYI the warnings seem to be caused by ember-cli/ember-fetch#391 |
What
Upgrade ember-fetch to 7.0.0 to resolve outdated browserslist warnings.
Close #1914
How
Just upgrade and test with live data (via
npm run start:live). No problems encountered.