Skip to content

Get rid of Browserslist: caniuse-lite is outdated. Please run next command npm update warning #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carols10cents opened this issue Nov 22, 2019 · 2 comments · Fixed by #2086
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear E-has-mentor

Comments

@carols10cents
Copy link
Member

I'm seeing this whenever I run npm run start:local and I'm starting to get annoyed :P

Here's another project having this problem and lots of people talking about the solutions

Implementation instructions

I'd love if someone could:

  • Verify that you currently see this message when you run npm run start:local
  • Figure out the minimum number of packages that need to be npm updated to make the message go away. That is, I'd like to not have to npm update everything-- updating anything in the lists below is fine with me.
  • Submit a PR with the updates needed to package.json and package-lock.json

I'm not sure if it's browserslist or caniuse-lite that needs to be updated? Or both? Or a parent?

 $ npm ls browserslist
[email protected] /Users/carolnichols/rust/crates.io
├─┬ @ember/[email protected]
│ └─┬ [email protected]
│   └─┬ @babel/[email protected]
│     ├── [email protected]
│     └─┬ [email protected]
│       └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected]

$ npm ls caniuse-lite
[email protected] /Users/carolnichols/rust/crates.io
├─┬ @ember/[email protected]
│ └─┬ [email protected]
│   └─┬ @babel/[email protected]
│     ├─┬ [email protected]
│     │ └── [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   ├─┬ [email protected]
│   │ └── [email protected]
│   └── [email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └── [email protected]  deduped

As of this writing, the latest browserslist is 4.7.3 and the latest caniuse-lite is 1.0.30001011.

@carols10cents carols10cents added A-frontend 🐹 A-ui C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear E-has-mentor labels Nov 22, 2019
@carols10cents carols10cents changed the title Get rid of Browserslist: caniuse-lite is outdated. Please run next command npm update Get rid of Browserslist: caniuse-lite is outdated. Please run next command npm update warning Nov 25, 2019
@hbina
Copy link
Contributor

hbina commented Nov 29, 2019

AFAIK, caniuse-lite will perpetually give out this warning every 6 months or so.

@carols10cents
Copy link
Member Author

Cool, a contribution opportunity every 6 months! :)

bors added a commit that referenced this issue Jan 4, 2020
manually run dependabot for caniuse-lite

It looks like dependabot is able to make a minimal incision and update
caniuse-lite without messing around with the rest of the package lock.
I suspect that dependabot will eventually get around to updating
caniuse-lite if we wait long enough, but I was curious to see how hard
it is to run manually, so I had a go. Turns out it's really easy, but
takes quite a long time.

Steps to reproduce:

* clone https://github.com/dependabot/dependabot-core
* docker pull dependabot/dependabot-core
* bin/docker-dev-shell
  * bin/dry-run.rb --dep caniuse-lite npm_and_yarn rust-lang/crates.io
* paste the printed patch into a file (e.g. patchfile.txt)
* patch package-lock.json patchfile.txt
* npm ci && npm start

Fixes #1914
@bors bors closed this as completed in 808fe7a Jan 4, 2020
@bors bors closed this as completed in #2086 Jan 4, 2020
@Turbo87 Turbo87 removed the A-ui label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear E-has-mentor
Projects
None yet
3 participants