manually run dependabot for caniuse-lite #2086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like dependabot is able to make a minimal incision and update caniuse-lite without messing around with the rest of the package lock. I suspect that dependabot will eventually get around to updating caniuse-lite if we wait long enough, but I was curious to see how hard it is to run manually, so I had a go. Turns out it's really easy, but takes quite a long time. Steps to reproduce: * clone https://github.com/dependabot/dependabot-core * docker pull dependabot/dependabot-core * bin/docker-dev-shell * bin/dry-run.rb --dep caniuse-lite npm_and_yarn rust-lang/crates.io * paste the printed patch into a file (e.g. patchfile.txt) * patch package-lock.json patchfile.txt * npm ci && npm start Fixes rust-lang#1914
|
r? @jtgeibel (rust_highfive has picked a reviewer for you, use r? to override) |
|
Awesome, thanks for the fix and detailed instructions! @bors r+ |
|
📌 Commit 808fe7a has been approved by |
bors
added a commit
that referenced
this pull request
Jan 4, 2020
manually run dependabot for caniuse-lite It looks like dependabot is able to make a minimal incision and update caniuse-lite without messing around with the rest of the package lock. I suspect that dependabot will eventually get around to updating caniuse-lite if we wait long enough, but I was curious to see how hard it is to run manually, so I had a go. Turns out it's really easy, but takes quite a long time. Steps to reproduce: * clone https://github.com/dependabot/dependabot-core * docker pull dependabot/dependabot-core * bin/docker-dev-shell * bin/dry-run.rb --dep caniuse-lite npm_and_yarn rust-lang/crates.io * paste the printed patch into a file (e.g. patchfile.txt) * patch package-lock.json patchfile.txt * npm ci && npm start Fixes #1914
|
☀️ Test successful - checks-travis |
|
@alsuren I'm curious, do you know what dependabot runs to perform this update? does it run some special |
|
I think it recursively deletes the dep from the lockfile and then runs npm install in this case. It has a bunch of different strategies, and calls npm via the JS API, so I might be misinterpreting things. |
|
I see, thanks. would be nice if npm had a builtin command for that like yarn has. or maybe we should switch back to yarn 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like dependabot is able to make a minimal incision and update
caniuse-lite without messing around with the rest of the package lock.
I suspect that dependabot will eventually get around to updating
caniuse-lite if we wait long enough, but I was curious to see how hard
it is to run manually, so I had a go. Turns out it's really easy, but
takes quite a long time.
Steps to reproduce:
Fixes #1914