Remove rustdoc CSS files import from non-rustdoc pages #1146
Conversation
GuillaumeGomez
force-pushed
the
remove-rustdoc-css-files
branch
from
304afd9 to
1bbacae
Compare
|
Updated! I also removed |
jyn514
added
the
S-waiting-on-review
jyn514
added
S-waiting-on-deploy
| font-family: 'Fira Sans'; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| src: local('Fira Sans'), url("FiraSans-Regular.woff") format('woff'); |
There was a problem hiding this comment.
I think those files are from the rustdoc essential files, which means starting an instance locally without building something before will result in broken styling.
I'm wondering if it's worth putting them in /-/static/fonts or something.
There was a problem hiding this comment.
I think it's the most stable part of rustdoc. They were here before I came in and they haven't changed since then. So moving them in a "static" location seems safe enough.
There was a problem hiding this comment.
@GuillaumeGomez I think pietro means that the files won't appear at all unless you run a build first. It would be nice to be able to use Fira Sans without having to first run a rustdoc build.
There was a problem hiding this comment.
Oh I see! Sending a PR shortly then.
jyn514
removed
the
S-waiting-on-deploy
Normally, if everything was done properly, no UI changes should appear.