Skip to content

Add fonts to static folder #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Conversation

GuillaumeGomez
Copy link
Member

Following discussion on #1146.

cc @pietroalbini @jyn514

@jyn514 jyn514 added A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 4, 2020
@Nemo157
Copy link
Member

Nemo157 commented Nov 4, 2020

The current static file handler doesn't actually support sub-directories afaik.

@GuillaumeGomez
Copy link
Member Author

Strange, it worked perfectly fine locally.

@GuillaumeGomez
Copy link
Member Author

I added the commit from #1158. :)

@GuillaumeGomez
Copy link
Member Author

I moved everything back one level up (didn't squash the commit though, for now I want to keep the "history" haha).

Copy link
Member

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it's working well

@jyn514 jyn514 merged commit 622b341 into rust-lang:master Nov 4, 2020
@GuillaumeGomez GuillaumeGomez deleted the static-fonts branch November 4, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants