Crate details page: when a build has failed, display a message that links to last successful build #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Jan 4, 2020
There was a problem hiding this comment.
I haven't run the code (on mobile) but it looks great! I'm very happy with how few changes you needed to get it working :)
The SCSS changes look reasonable but I haven't written SCSS before. @GuillaumeGomez do you mind reviewing?
|
One more test request: can you add a test for when a build fails and then a later build succeeds? e.g. 0.1 fails and 0.2 succeeds, I would expect the error for 0.1 to have a link to 0.2. After that I feel comfortable merging :) |
|
I have added the extra test case 👍 |
yvrhdn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of #516.
When a build of a release failed and any other release was successfully built (before or after this release), this commit will add a message that links to the last successful build.
If no other release was built successfully, this message will not be displayed.
I had to extend
test::fakes::FakeReleasea bit to be able to create a test with releases that had failed to build.And I also adapted
style.scssa bit:div.infois the base styling of a message boxdiv.warninginherits all properties ofdiv.infobut setsbackground-colorto orangeThere might be cleaner ways to do this, I am not a SCSS expert 😅
Crate details page before this PR (https://docs.rs/crate/fie/0.16.2):
Crate details page after this PR:
The displayed link is
/crate/fie/0.15.0, which will resolve to https://docs.rs/crate/fie/0.15.0