-
Notifications
You must be signed in to change notification settings - Fork 212
Crate details page: show whether a build failed in the Versions list #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good! You'll have to rebase over master since #543 got merged. I also left a few minor nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge once you fix the nit :)
I'm really looking forward to having this, thanks again for your hard work! |
CrateDetails: replace field 'versions' with 'releases', which contains both the version and the build status of a release. Since CrateDetails::versions was a public field, CrateDetails::versions() is designed to be compatible with the previous exposed field.
Implements second change related to #516.
I was planning to rebase these commits on top of the commits in #543 if that PR gets approved & merged. But this can be merged indepedently.
This pull request changes the Crate Details page to display whether a build failed in the Versions list.
Current design:
Page after these commits:
I performed the changes in two commits, this should make it a bit easier to reason about them. Hopefully...
521b8ae
da358f8
CrateDetails
I replaced the fieldversions
withreleases
. The type changed from a raw String toRelease
, which holds aversion
string and abuild_status
boolean.versions()
which has the same behaviour as the removedversions
field.releases
inCrateDetails::new
but I took care to change as little code as possible. Hence the introduction ofmap_to_release
. This entire function can be refactored to be more efficient / perform less queries on the database, but that's for a later PR.crate_details.hbs
to use the additional information and show a