Skip to content

ci: install musl from source for loongarch64 #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Mar 11, 2025

Description

This patch switches to installing musl from source for the LoongArch64 target to ensure compatibility between kernel headers and Rust bindings.

Sources

None.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

The change itself looks fine to me, but will this cause any problems with time_t? Since the change from 32- to 64-bit time happened at 1.2.0.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this only affects a 64-bit arch that didn't have the time change. Hopefully this won't cause any problems using a different version than the rest of the platforms, but I don't have any reason not to try it.

@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
Merged via the queue into rust-lang:main with commit e289552 Mar 22, 2025
43 checks passed
@heiher heiher deleted the ci-loong64-musl branch March 22, 2025 02:22
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants