-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Clean up some test skips on Linux #4328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also shifts some constants to the musl guard check Signed-off-by: Pedro Tammela <pctammela@gmail.com>
The added #[repr(8)] was spurious and added an extra 4 bytes of padding Signed-off-by: Pedro Tammela <pctammela@gmail.com>
Signed-off-by: Pedro Tammela <pctammela@gmail.com>
Depends on: #4320 |
Signed-off-by: Pedro Tammela <pctammela@gmail.com>
0651227
to
cf17b4e
Compare
pub const PR_SME_VL_LEN_MAX: c_int = 0xffff; | ||
|
||
pub const PR_SME_SET_VL_INHERIT: c_ulong = 1 << 17; | ||
pub const PR_SME_SET_VL_ONE_EXEC: c_ulong = 1 << 18; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is something that makes sense to remove, I'd rather only deprecate it here so I can backport the PR. We'll go through and do a sweep of deprecated items before 1.0.
@rustbot author from the review above |
Reminder, once the PR becomes ready for a review, use |
@tgross35 I'm unavailable currently and will be for some time. Trevor (or anyone else), feel free to continue this PR if you can! |
Description
Since I added a bunch of new skips I decided to remove some of the stale ones
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI