Skip to content

Clean up some test skips on Linux #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tammela
Copy link
Contributor

@tammela tammela commented Mar 12, 2025

Description

Since I added a bunch of new skips I decided to remove some of the stale ones

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

tammela added 2 commits March 12, 2025 16:58
Also shifts some constants to the musl guard check

Signed-off-by: Pedro Tammela <pctammela@gmail.com>
The added #[repr(8)] was spurious and added an extra 4 bytes of padding

Signed-off-by: Pedro Tammela <pctammela@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 12, 2025
Signed-off-by: Pedro Tammela <pctammela@gmail.com>
@rustbot rustbot added the O-gnu label Mar 13, 2025
@tammela
Copy link
Contributor Author

tammela commented Mar 13, 2025

Depends on: #4320

Signed-off-by: Pedro Tammela <pctammela@gmail.com>
@tammela tammela force-pushed the linux-tests-cleanup branch from 0651227 to cf17b4e Compare March 14, 2025 18:07
Comment on lines -634 to -637
pub const PR_SME_VL_LEN_MAX: c_int = 0xffff;

pub const PR_SME_SET_VL_INHERIT: c_ulong = 1 << 17;
pub const PR_SME_SET_VL_ONE_EXEC: c_ulong = 1 << 18;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for removing these? I can't actually find them defined anywhere, @devnexen do you remember what these are from in #3116?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is something that makes sense to remove, I'd rather only deprecate it here so I can backport the PR. We'll go through and do a sweep of deprecated items before 1.0.

@tgross35
Copy link
Contributor

tgross35 commented Apr 2, 2025

@rustbot author from the review above

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@tammela
Copy link
Contributor Author

tammela commented Apr 22, 2025

@tgross35 I'm unavailable currently and will be for some time. Trevor (or anyone else), feel free to continue this PR if you can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-gnu O-linux O-unix S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants