Skip to content

Fix allowing unused_self on fn #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix allowing unused_self on fn #5062

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2020

Closes #5053

changelog: Fix allowing unused_self on fn

@JohnTitor
Copy link
Member

The easier way is to use check_impl_item instead of check_item.
See also: JohnTitor@ff0a22d

@ghost
Copy link
Author

ghost commented Jan 18, 2020

Yes, you're right. You should make a PR for your version and I'll close this one.

@ghost ghost closed this Jan 18, 2020
@JohnTitor
Copy link
Member

Ah, sorry, I didn't intend to steal your contribution. But thanks for your kind consideration!

@JohnTitor JohnTitor mentioned this pull request Jan 18, 2020
Merged
bors added a commit that referenced this pull request Jan 18, 2020
@bors
Auto merge of #5063 - JohnTitor:allow-correctly, r=flip1995
ee06aa9 
Allow `unused_self` lint at the function level

Another approach of #5062.
Fixes #5053

changelog: Allow `unused_self` lint at the function level
@ghost ghost deleted the fix-5053-2 branch June 24, 2020 05:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to allow unused_self after enabling pedantic
1 participant
@JohnTitor