Skip to content

Allow unused_self lint at the function level #5063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

Allow unused_self lint at the function level #5063

merged 1 commit into from
Jan 18, 2020

Conversation

JohnTitor
Copy link
Member

Another approach of #5062.
Fixes #5053

changelog: Allow unused_self lint at the function level

@flip1995
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Jan 18, 2020

📌 Commit ff0a22d has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jan 18, 2020

⌛ Testing commit ff0a22d with merge ee06aa9...

bors added a commit that referenced this pull request Jan 18, 2020
@bors
Auto merge of #5063 - JohnTitor:allow-correctly, r=flip1995
ee06aa9 
Allow `unused_self` lint at the function level

Another approach of #5062.
Fixes #5053

changelog: Allow `unused_self` lint at the function level
@bors
Copy link
Contributor

bors commented Jan 18, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing ee06aa9 to master...

@bors bors merged commit ff0a22d into rust-lang:master Jan 18, 2020
@JohnTitor JohnTitor deleted the allow-correctly branch January 18, 2020 19:06
@martinthomson
Copy link

Thanks for this. I'm also running into the same problem with #[allow(clippy::use_self)] (which has some other issues causing me to need to have suppression, ideally function-scoped). Another issue?

@JohnTitor
Copy link
Member Author

@martinthomson Let me take a look. Also, you can file it as a new issue.

@martinthomson
Copy link

Opened #5078. Thanks.

@flip1995 flip1995 mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to allow unused_self after enabling pedantic
4 participants
@JohnTitor @flip1995 @bors @martinthomson