Skip to content

Fix a false positive in unnecessary_wraps #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2020
Merged

Fix a false positive in unnecessary_wraps #6397

merged 2 commits into from
Nov 28, 2020

Conversation

hkmatsumoto
Copy link
Member

Fix #6384

changelog: Fix FP in unnecessary_wraps that happens when Call expr has Return expr inside

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 28, 2020
@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 28, 2020
flip1995
flip1995 approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on #6396

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2020

📌 Commit 2c26cb1 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 28, 2020

⌛ Testing commit 2c26cb1 with merge 6cbb093...

@bors
Copy link
Contributor

bors commented Nov 28, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6cbb093 to master...

@bors bors merged commit 6cbb093 into rust-lang:master Nov 28, 2020
@hkmatsumoto hkmatsumoto deleted the fix-6384 branch November 29, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary_wraps misses 'return'
4 participants
@hkmatsumoto @rust-highfive @flip1995 @bors