Trouble passing closures with borrowed pointers inside options #10846
Labels
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
Comments
|
visiting for triage. It can be simplified to: It's erroring with: |
|
cc me. This may be blocking some work on Servo. |
|
cc me |
|
Slightly simpler test case: #![crate_type="lib"]
fn erickt_fn() {
fn test2(_x: Option<|f: |g: &int||>) {}
test2(Some(|_f: |g: &int|| {}));
}Also, I found the problem goes away if you manually lift the closure types into #[cfg(show_erickt_bug)]
fn erickt_fn() {
fn test2(_x: Option<|y: Option<|z: &int|>|>) {}
test2(Some(|_y: Option<|z: &int|>| {}));
}
#[cfg(not(show_erickt_bug))]
fn erickt_fn() {
type F1<'a> = |z: &'a int|:'a;
type F2<'b> = |y: Option<F1<'b>>|:'b;
fn test2<'c>(_x: Option<F2>) {}
test2(Some(|_y| {}))
}This probably reflects some change where the lifetimes go from being late-bound to being early bound. The version with |
|
The type item versions are not equivalent because they don't have any bound lifetimes. Niko -------- Original message -------- Slightly simpler test case: #![crate_type="lib"] fn erickt_fn() { This probably reflects some change where the lifetimes go from being late-bound to being early bound. The version with type items might not be handle cases that the version with inlined closure types can handle, I'm not 100% sure yet. — |
pnkfelix
added a commit
to pnkfelix/rust
that referenced
this issue
Jun 22, 2014
In other words, Late-bound regions that occur non-free should be skipped. Fix rust-lang#10846.
bors
added a commit
that referenced
this issue
Jun 23, 2014
In other words, Late-bound regions that occur non-free should be skipped. Fix #10846 (specifically the ICE, not the weakness in the current type inference).
This was referenced Jun 23, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Jun 2, 2023
This commit fixes rust-lang#10846 by checking if the path segment contains the word "prelude". Signed-off-by: Charalampos Mitrodimas <[email protected]>
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Jun 2, 2023
… r=llogiq [`wildcard_imports`] Modules that contain `prelude` are also allowed This commit fixes rust-lang#10846 by checking if the path segment contains the word "prelude", allowing us `use module_prelude::*`. changelog: [`wildcard_imports`]: Modules that contain `prelude` are also allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rustc 0.9-pre (aa4455e 2013-12-06 01:11:18 -0800)Consider this code and errors:
As you can see, in case of
test1, it has trouble inferring the type of the closure parameter, but if you specify it manually it works. In the case oftest2specifying it manually crashes the compiler outright. Note that both cases work just fine if you remove all theOptions.The text was updated successfully, but these errors were encountered: