Fix ICE: RegionFolder should only invoke callback on free regions. #15061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be specific: this PR fixes the ICE described on #10846. The type inference failure is a separate issue that may or may not be immediately fixable. I am still looking into that, but I think we should try to land a fix for the ICE sooner if possible. |
|
r+ modulo nit. |
In other words, Late-bound regions that occur non-free should be skipped. Fix rust-lang#10846.
|
(aforementioned nit was a request for an alpha-rename of the helper function I introduced, which I did, though I chose a variation on the names niko had suggesed.) |
pnkfelix
changed the title
bors
added a commit
that referenced
this pull request
Jun 23, 2014
In other words, Late-bound regions that occur non-free should be skipped. Fix #10846 (specifically the ICE, not the weakness in the current type inference).
|
As noted in the PR and the merge commit, only the ICE was addressed; there is still the weakness in the type inference algorithm. I will open a new ticket regarding trying to improve our type inference for this case. |
|
also I should have included a regression test in the PR. Will open a ticket for that as well. |
This was referenced Jun 23, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2023
…ith-tail-expr, r=Veykril fix: don't use control flow when extracted fn contains tail expr of original fn Fixes rust-lang#10113 Fixes rust-lang#15061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other words, Late-bound regions that occur non-free should be
skipped.
Fix #10846 (specifically the ICE, not the weakness in the current type inference).