mark bounds check failures as the cold path #10113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM is unable to determine this for most cases. http://llvm-reviews.chandlerc.com/D2034 needs to land upstream before this is going to have an effect. It's harmless to start generating the expect hint now.
bors
added a commit
that referenced
this pull request
Oct 28, 2013
LLVM is unable to determine this for most cases. http://llvm-reviews.chandlerc.com/D2034 needs to land upstream before this is going to have an effect. It's harmless to start generating the expect hint now.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 29, 2022
…_suggestion, r=Jarcho fix incorrect suggestion in `suboptimal_flops` fixes rust-lang#10003 There was an error when trying to negate an expression like `x - 1.0`. We used to format it as `-x - 1.0` whereas a proper negation would be `-(x - 1.0)`. Therefore, we add parentheses around the expression when it is `ExprKind::Binary`. We also add parentheses around multiply and divide expressions, even though this is not strictly necessary. changelog: [`suboptimal_flops`]: fix incorrect suggestion caused by an incorrect negation of floating point expressions.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2023
…ith-tail-expr, r=Veykril fix: don't use control flow when extracted fn contains tail expr of original fn Fixes rust-lang#10113 Fixes rust-lang#15061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM is unable to determine this for most cases.
http://llvm-reviews.chandlerc.com/D2034 needs to land upstream before
this is going to have an effect. It's harmless to start generating the
expect hint now.