Skip to content

regression: error[E0308]: mismatched types for is_multiple_of #140020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cuviper opened this issue Apr 18, 2025 · 4 comments
Closed

regression: error[E0308]: mismatched types for is_multiple_of #140020

cuviper opened this issue Apr 18, 2025 · 4 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@cuviper cuviper added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Apr 18, 2025
@cuviper cuviper added this to the 1.87.0 milestone Apr 18, 2025
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-untriaged Untriaged performance or correctness regression. labels Apr 18, 2025
@cuviper
Copy link
Member Author

cuviper commented Apr 18, 2025

This is probably expected fallout from #128101 (still open?) and #137383, and we can just close if the impact is considered acceptable.

For num-integer's part, the breakage was only in a test, already fixed in rust-num/num-integer#69.

@cuviper
Copy link
Member Author

cuviper commented Apr 18, 2025

cc @rust-lang/libs-api

@jieyouxu jieyouxu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 19, 2025
@joshtriplett
Copy link
Member

Yes, this was expected.

@Amanieu
Copy link
Member

Amanieu commented Apr 23, 2025

We discussed this in the @rust-lang/libs meeting and confirm that this is an expected regression. We don't plan to roll it back considering the relatively limited fallout.

@Amanieu Amanieu closed this as completed Apr 23, 2025
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants