Book should be printable

[vrinek]

Currently if you try printing the book it comes out blank.

There is something missing in the CSS. I am already on it and have a hunch what it might be but wanted to post it here in case someone else wants to give it a hand or even carry it further (make it pretty perhaps?).

[jroesch]

cc @steveklabnik

[frewsxcv]

@vrinek Are you trying to print a single page or the whole book?

[vrinek]

I'm only trying to print a single page for now. Sadly I have failed to find where rust-book.css is generated from (after deleting https://github.com/rust-lang/rust/blob/master/src/doc/trpl/rust-book.css, it kept regenerating).

The changes I want to do are showcased here: https://github.com/rust-lang/rust/blob/master/src/doc/trpl/rust-book.css.

If someone could point me to the right place where I should apply these changes, I would be grateful.

[frewsxcv]

FWIW, If I try to print a single page it doesn't show up blank

That said, there's still room for improvement. What browser/OS are you using? I'm using OSX with the latest stable Firefox.

[sfackler]

It comes out pretty busted with Chrome on OSX:

[iKevinY]

Safari on OS X acts the same way as shown in @sfackler's screenshot, so maybe it's WebKit-related?

[frewsxcv]

Even if WebKit/Blink was able to replicate my Firefox screenshot, I'd say there still needs to be better print styling defaults. For example, we probably won't need the sidebar.

[steveklabnik]

It's generated from https://github.com/rust-lang/rust/blob/master/src/rustbook/javascript.rs

[steveklabnik]

(and we have a few other issues open about print CSS too)

[bluss]

If you try to print a longer chapter, you'll see that you get only the first page (Firefox). That's more than bad styling :)

[frewsxcv]

@steveklabnik If you can easily find the other print CSS related issues, it might benefit this issue for the sake of deduplicating issues. The only I found was this one

[steveklabnik]

@frewsxcv that was the one on the top of my head, maybe it's just that one

[vrinek]

@steveklabnik I bet you meant https://github.com/rust-lang/rust/blob/master/src/rustbook/css.rs (the one you linked was javascript). I'll fix it up and send a PR.

[steveklabnik]

err yes, I did. Nice catch 😅

[vrinek]

PR ready: #21962

[mdinger]

PR #21962 merged so this should be fixed and closable.