Skip to content

Printable book #21962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2015
Merged

Printable book #21962

merged 2 commits into from
Feb 6, 2015

Conversation

vrinek
Copy link
Contributor

@vrinek vrinek commented Feb 5, 2015

Tested on:

  • Safari on OSX
  • Firefox on OSX

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@vrinek vrinek mentioned this pull request Feb 5, 2015
@huonw
Copy link
Member

huonw commented Feb 5, 2015

r? @steveklabnik

@steveklabnik
Copy link
Member

Is there any chance you could post a version online so I could check it out on Linux?

@vrinek
Copy link
Contributor Author

vrinek commented Feb 5, 2015

I did a make docs and pushed a gh-pages on my repo. It's viewable at http://blog.vrinek.io/rust/doc/book/index.html.

@steveklabnik
Copy link
Member

@bors: r+ a40df9d

@steveklabnik
Copy link
Member

Thank you! Looks great here too.

@thiagooak
Copy link
Contributor

Adding

@media only print {
  #page-wrapper {
     margin-left: 30px;
  }
}

would fix #17426 also

not sure what would be the ideal size, 30px looks reasanable

bors added a commit that referenced this pull request Feb 6, 2015
Tested on:

* Safari on OSX
* Firefox on OSX
@bors
Copy link
Collaborator

bors commented Feb 6, 2015

⌛ Testing commit a40df9d with merge 0b56e9b...

@bors bors merged commit a40df9d into rust-lang:master Feb 6, 2015
@vrinek vrinek deleted the printable-book branch February 8, 2015 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants